Patch Set 1: (2 comments)
https://gerrit.osmocom.org/#/c/4446/1/src/osmo-bts-octphy/l1_oml.c File src/osmo-bts-octphy/l1_oml.c: Line 55: int no_fw_check = 0; It it's used as boolean, than why not use "bool" type for it to make that obvious? Line 1170: "Invalid header-file-version / dsp-firmware-version combination\n"); While at it, might make sense to print the actual versions too. -- To view, visit https://gerrit.osmocom.org/4446 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5774fbb29da832786326afb991014b9bd8b04b59 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
