fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25285 )
Change subject: rsl: parse temporary overpower value RSL CHAN ACT / MODIFY ...................................................................... Patch Set 3: > Patch Set 3: Code-Review+1 > > So right now if BTS doesn't support the IE but it finds it, it will fail. This is why osmo-bsc needs to make sure that a BTS reports BTS_FEAT_ACCH_TEMP_OVP as supported before including this optional and vendor specific IE in the RSL messages. And this is what it actually does. > Shouldn't it simply ignore it IMHO? I don't think it's a good idea to ignore something that the BSC requires us to do, at least because it's harder to figure out why something does not work as expected, despite being ACKed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I426c2510865c4a986c68f2027cc676aaac0d8a4c Gerrit-Change-Number: 25285 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 27 Sep 2021 15:52:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
