osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gbproxy/+/25077 )

Change subject: gbproxy: Route BSSGP STATUS with PDU_IN_ERROR containing a TLLI
......................................................................


Patch Set 4:

(2 comments)

LGTM besides cosmetics

https://gerrit.osmocom.org/c/osmo-gbproxy/+/25077/4/src/gb_proxy.c
File src/gb_proxy.c:

https://gerrit.osmocom.org/c/osmo-gbproxy/+/25077/4/src/gb_proxy.c@1000
PS4, Line 1000: "FOO"
prefix for log messages: FOO? :)

(also: long line)


https://gerrit.osmocom.org/c/osmo-gbproxy/+/25077/4/src/gb_proxy.c@1130
PS4, Line 1130:                  * if we can extract a TLLI/RNI to route it to 
the correct SGSN */
looks like the fixme is now implemented?



--
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/25077
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I9d2ec73520ee46ceedda3f7e63035e6a51a65ac2
Gerrit-Change-Number: 25077
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 29 Sep 2021 14:03:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to