Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25622 )
Change subject: gsmtap: allow 127.0.0.x local listeners ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/25622/1/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/25622/1/src/socket.c@1141 PS1, Line 1141: uint32_t address = ((struct sockaddr_in *)a)->sin_addr.s_addr; /* already BE */ > what about ipv6? no, see the check above https://gerrit.osmocom.org/c/libosmocore/+/25622/1/src/socket.c@1160 PS1, Line 1160: if (sockaddr_is_local_routed(addr)) > IIRC the 127.0.0. […] the function itself does all the work including the check, as it should. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1043dfd8075f14481011f43db45c943e9320413c Gerrit-Change-Number: 25622 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 04 Oct 2021 14:05:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
