laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25447 )
Change subject: adjust mgcp response context ...................................................................... Patch Set 5: (3 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25447/5/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25447/5/src/libosmo-mgcp/mgcp_protocol.c@179 PS5, Line 179: msg = msgb_alloc_c(ctx, 4096, "MGCP msg"); > I think you should use msgb_alloc_headroom_c() here. […] nice catch https://gerrit.osmocom.org/c/osmo-mgw/+/25447/5/src/libosmo-mgcp/mgcp_protocol.c@244 PS5, Line 244: static struct msgb *create_ok_resp_with_param(void *msgctx, struct mgcp_endpoint *endp, int code, const char *msg, > maybe you should keep the 80 column limit here. This is old code. […] I don't see any of this as critical. https://gerrit.osmocom.org/c/osmo-mgw/+/25447/5/src/libosmo-mgcp/mgcp_protocol.c@287 PS5, Line 287: msgb_reserve(sdp, 128); > same as above, I would use msgb_alloc_headroom_c() ack -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8 Gerrit-Change-Number: 25447 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Tue, 12 Oct 2021 16:27:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
