pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/25945 )
Change subject: bts-trx: sched: tx_pdtch_fn: Drop log line clogging logs
......................................................................
bts-trx: sched: tx_pdtch_fn: Drop log line clogging logs
The burst is properly pre-filled to _sched_dummy_burst in
bts_sched_init_buffers(), so we are fine doing nothing on C0.
Related: SYS#5676
Related: SYS#4919
Fixes: 300e31ed135c674cd44526b7503d4664a45a9ec3
Change-Id: Ia7045724a1a3206f5890c0b12843711ad2360ed8
---
M src/osmo-bts-trx/sched_lchan_pdtch.c
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bts-trx/sched_lchan_pdtch.c
b/src/osmo-bts-trx/sched_lchan_pdtch.c
index 4c63acb..66be116 100644
--- a/src/osmo-bts-trx/sched_lchan_pdtch.c
+++ b/src/osmo-bts-trx/sched_lchan_pdtch.c
@@ -162,7 +162,11 @@
/* get mac block from queue */
msg = _sched_dequeue_prim(l1ts, br);
if (!msg) {
- LOGL1SB(DL1P, LOGL_INFO, l1ts, br, "No prim for transmit.\n");
+ /* It's totally fine to get no block here, since PCU may submit
+ * empty blocks when there's no MS listening. The scheduler will
+ * take care of filling C0 with dummy bursts to keep expected
+ * power transmit levels
+ */
goto no_msg;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25945
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia7045724a1a3206f5890c0b12843711ad2360ed8
Gerrit-Change-Number: 25945
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
