laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20296 )
Change subject: logging: Change stderr + file target to use non-blocking write ...................................................................... Patch Set 15: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/20296/15/src/logging.c File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/20296/15/src/logging.c@920 PS15, Line 920: fprintf(target->tgt_file.out, "%s", log); > how about: […] Done https://gerrit.osmocom.org/c/libosmocore/+/20296/15/src/logging.c@1084 PS15, Line 1084: /* close the write queue file descriptor */ > With this comment, I would have expected close() here - but that's happening > only later on. […] Done https://gerrit.osmocom.org/c/libosmocore/+/20296/15/src/logging.c@1099 PS15, Line 1099: block > write? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia58fd78535c41b3da3aeb7733aadc785ace610da Gerrit-Change-Number: 20296 Gerrit-PatchSet: 15 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 26 Oct 2021 15:16:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osm...@sysmocom.de> Gerrit-MessageType: comment
