pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26011 )
Change subject: bsc_subscr_conn_fsm: fix mgw-pool ref counting ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26011/1/src/osmo-bsc/bsc_subscr_conn_fsm.c File src/osmo-bsc/bsc_subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26011/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@961 PS1, Line 961: mgcp_client = osmo_mgcpc_ep_client(conn->user_plane.mgw_endpoint); > I think all functions with _free() must be NULL pointer safe, otherwise you > don't call the function […] That's exactly what I said. But this is non a _free() function, so I wouldn't expect it to be null safe, even if it is implementation wise to be more secure. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5a7ce6a1880a1060df74d03dd4eb38b51fd85c69 Gerrit-Change-Number: 26011 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Fri, 29 Oct 2021 12:52:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
