pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26015 )
Change subject: Drop unused fields in struct hnb ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26015/1/include/osmocom/hnodeb/hnodeb.h File include/osmocom/hnodeb/hnodeb.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26015/1/include/osmocom/hnodeb/hnodeb.h@a85 PS1, Line 85: char identity_info[256]; : /*! copied from Cell Identity IE */ : struct umts_cell_id id; > I'd say the proper fix is to make those identifiers vty-configurable, store > them here and then use t […] That's what I'm doing in follow up patches. I think I can get rid of struct umts_cell_id id defintiion in this patch too, I'm not using it. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26015 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ia981d99bf521eb8b79bdf8d7f81ca50f6cdeba8c Gerrit-Change-Number: 26015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Fri, 29 Oct 2021 12:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
