pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26001 )
Change subject: Allocate g_hnb as a pointer, move code to hnb.c/h ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26001/1/src/osmo-hnodeb/hnb.c File src/osmo-hnodeb/hnb.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26001/1/src/osmo-hnodeb/hnb.c@65 PS1, Line 65: if (rc < 0) { > BTW (I know you're just moving stuff around), we have msg leak here. Fixed here: https://gerrit.osmocom.org/c/osmo-iuh/+/26031 hnb-test: Fix memleak in hnb_read_cb https://gerrit.osmocom.org/c/osmo-hnodeb/+/26032 hnb.c: Fix memleak in hnb_iuh_read_cb -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5ec61d2a72d55d182e1498939209b30b6e652467 Gerrit-Change-Number: 26001 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 29 Oct 2021 13:50:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
