pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021 )
Change subject: Configure CI,LAC,RAC,SAC over VTY and use it in HnbRegisterRequest ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021/1/src/osmo-hnodeb/vty.c File src/osmo-hnodeb/vty.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021/1/src/osmo-hnodeb/vty.c@135 PS1, Line 135: cell_identity > Do we want to inherit this inconsistency from osmo-{bsc,msc}? […] I have no hard opinion on this, I simply kept them as we have them in osmo-bsc/msc/... for consistency. @laforge? In any case this can be changed as a follow up patch if we want to do so. https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021/1/src/osmo-hnodeb/vty.c@245 PS1, Line 245: vty_out(vty, " cell_identity %u%s", g_hnb->cell_identity, VTY_NEWLINE); > Ack, something is wrong here. […] Maybe as a follow up patch, once we merge the bulk of changes. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I06f21758e361b7d4d7141086d758893bee434e5c Gerrit-Change-Number: 26021 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Fri, 29 Oct 2021 15:37:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
