neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25734 )
Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries ...................................................................... Patch Set 5: (3 comments) https://gerrit.osmocom.org/c/osmo-bts/+/25734/5/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/25734/5/src/common/oml.c@602 PS5, Line 602: ) p usually no space after type cast https://gerrit.osmocom.org/c/osmo-bts/+/25734/5/src/common/oml.c@605 PS5, Line 605: bts->interference.band_map[i] = 6 - i; i'm a bit confused by '5 - i' vs '6 - i' https://gerrit.osmocom.org/c/osmo-bts/+/25734/5/src/common/oml.c@608 PS5, Line 608: bts->interference.band_map[i] = i; ...especially because there is no diff-by-one involved here -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Comment-Date: Mon, 08 Nov 2021 15:37:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
