laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25447 )
Change subject: adjust mgcp response context ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/25447/6/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25447/6/src/libosmo-mgcp/mgcp_protocol.c@187 PS6, Line 187: msgb_reserve(msg, 128); > Ah I see, so there's no msgb_alloc_headroom_c() I guess. There is msgb_alloc_headroom_c() since 2019: commit 179f35702ece13f4ab7fd1b331bef664834d8473 Author: Harald Welte <[email protected]> Date: Mon Mar 18 18:38:47 2019 +0100 So I would argue to use it. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8 Gerrit-Change-Number: 25447 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 11 Nov 2021 09:11:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
