osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libusrp/+/19675 )
Change subject: migrate to python3 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libusrp/+/19675/2/firmware/src/common/build_eeprom.py File firmware/src/common/build_eeprom.py: https://gerrit.osmocom.org/c/libusrp/+/19675/2/firmware/src/common/build_eeprom.py@87 PS2, Line 87: key=lambda a: a.addr > Not sure if this change is correct. looks correct according to https://stackoverflow.com/a/403426 also I've verified that the generated files are the same in both versions. $ git checkout master $ autoreconf -fi $ ./configure $ make $ cp firmware/src/usrp2/burn-usrp* /tmp/ $ make distclean $ git review -d 19675 $ autoreconf -fi $ ./configure $ make $ diff -s /tmp/burn-usrp2-eeprom firmware/src/usrp2/burn-usrp2-eeprom Files /tmp/burn-usrp2-eeprom and firmware/src/usrp2/burn-usrp2-eeprom are identical $ diff -s /tmp/burn-usrp4-eeprom firmware/src/usrp2/burn-usrp4-eeprom Files /tmp/burn-usrp4-eeprom and firmware/src/usrp2/burn-usrp4-eeprom are identical -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/19675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Ib1604b36c32630e1360e06567cbd5f63a78df547 Gerrit-Change-Number: 19675 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: roox <[email protected]> Gerrit-Comment-Date: Fri, 12 Nov 2021 10:48:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
