fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 )
Change subject: pcu: Introduce as_ms_rx_ignore_empty helper ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn@562 PS1, Line 562: inout GprsMS ms > It's the same as with as_ms_rx_ignore_dummy above. […] I expected this kind of answer, but neither dummy nor empty DATA.req messages contain MS specific info. I simply don't see how GprsMS might be used in the context of empty DATA.req messages, or how can this altstep might evolve in the future so that GprsMS is needed. And same applies to as_ms_rx_ignore_dummy() - requiring the API user to pass aruments for no real need is a bad idea. IMO, both altsteps should not require GprsMS and rather use "as_pcuif_" prefix. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c Gerrit-Change-Number: 26220 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 12 Nov 2021 18:19:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
