pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 )
Change subject: Add multithreading for the virtual trunk ...................................................................... Patch Set 35: (6 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/include/osmocom/mgcp/mgcp_trunk.h File include/osmocom/mgcp/mgcp_trunk.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/include/osmocom/mgcp/mgcp_trunk.h@30 PS35, Line 30: unsigned int why is this broken into 2 lines? https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_protocol.c@1554 PS35, Line 1554: { same line https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_threads.c File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_threads.c@199 PS35, Line 199: { same line https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_threads_vty.c File src/libosmo-mgcp/mgcp_threads_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_threads_vty.c@162 PS35, Line 162: { same line https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_vty.c@1379 PS35, Line 1379: if (strcmp(argv[3], "in") == 0) missing {} here. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/osmo-mgw/mgw_main.c File src/osmo-mgw/mgw_main.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/osmo-mgw/mgw_main.c@326 PS35, Line 326: { This was changed to a new line but the code style specs it to be in the same one in for loops. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 35 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Thu, 18 Nov 2021 09:52:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
