laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26370
)
Change subject: fix: Decoder may raise KeyError
......................................................................
fix: Decoder may raise KeyError
This fixes an issue where a KeyError may be raised when 'A5'
is not present in `fcp`
Change-Id: I5bb6131bd76c7bae2a70034c429cae2b380d164f
---
M pySim/ts_102_221.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, but someone else must approve
dexter: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py
index adb40c1..f145d19 100644
--- a/pySim/ts_102_221.py
+++ b/pySim/ts_102_221.py
@@ -684,7 +684,7 @@
fcp_tlv = TLV(FCP_TLV_MAP)
fcp = fcp_tlv.parse(fcp_base['62'])
# further decode the proprietary information
- if fcp['A5']:
+ if 'A5' in fcp:
prop_tlv = TLV(FCP_Proprietary_TLV_MAP)
prop = prop_tlv.parse(fcp['A5'])
fcp['A5'] = tlv_val_interpret(FCP_prorietary_interpreter_map, prop)
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/26370
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5bb6131bd76c7bae2a70034c429cae2b380d164f
Gerrit-Change-Number: 26370
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-MessageType: merged
