laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26459 )
Change subject: move tlv.h, tlv_parser.c from libosmogsm to libosmocore ...................................................................... Patch Set 1: > Patch Set 1: > > linter doesn't like our old tlv.h > > But another thing: turns out that PFCP has 16 bit tags, so tlv.h as it is > won't be useful for PFCP at all. you might be able to generalize the xua_msg code from libosmo-sigtran. The M3UA/SUA/... messages have 16bit tags, and the parser builds dynamically-allocated linked-list representations of the messages, which also supports repeated tags, ... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cda0143af9eaf90dc73f9deccd651117fdf8845 Gerrit-Change-Number: 26459 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Comment-Date: Tue, 07 Dec 2021 19:36:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
