osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 )
Change subject: Add project skeleton ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/configure.ac File configure.ac: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/configure.ac@53 PS1, Line 53: P > will we need ASN. […] Done https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/jenkins.sh File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/jenkins.sh@32 PS1, Line 32: osm > does not include libasn1c which configure.ac is requiring (probably wrongly > so). Ack https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/osmo-bsc-nat.spec.in File contrib/osmo-bsc-nat.spec.in: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/osmo-bsc-nat.spec.in@41 PS1, Line 41: Bui > why would we need libosmogb here? configure.ac doesn't list it, and I cannot > think of a reason. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Iae5d37483dcb9db00578d5c9cd1736f08754a65e Gerrit-Change-Number: 26658 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Thu, 23 Dec 2021 09:48:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
