pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26722 )
Change subject: iu_helpers: make new_transp_info_(rtp|gtp) public ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Ah I see now you just made them public. I don't see why those functions need to be moved to a different file though, simple remove the static flag and add them to the header file. https://gerrit.osmocom.org/c/osmo-iuh/+/26722/1/include/osmocom/ranap/iu_helpers.h File include/osmocom/ranap/iu_helpers.h: https://gerrit.osmocom.org/c/osmo-iuh/+/26722/1/include/osmocom/ranap/iu_helpers.h@16 PS1, Line 16: RANAP_TransportLayerInformation_t *new_transp_info_rtp(uint32_t ip, uint16_t port, bool use_x213_nsap); This looks wrong. Is only IPv4 supported? You should pass a struct sockaddr* here instead of ip + port (hint: you can use struct osmo_sockaddr in the implementation or/and in the caller to convert/fill it) -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1e369718de8c4c7db1f1af1e6864562164ada6cf Gerrit-Change-Number: 26722 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:02:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
