Patch Set 1: Code-Review+2 (2 comments)
https://gerrit.osmocom.org/#/c/4423/1/src/osmo_gsm_tester/util.py File src/osmo_gsm_tester/util.py: Line 55: proc = subprocess.Popen(['sudo', 'osmo-gsm-tester_setcap_net_raw.sh', binary], stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True) (would prefer to log the complete command line called like we do in process.py ... or if there's nothing blocking it best even use the Process class here?) Line 60: raise RuntimeError('setcap_net_raw subprocess finished with err code %d' % proc.returncode) (would prefer to name the script completely in the error message) -- To view, visit https://gerrit.osmocom.org/4423 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3eb24461c02173dc80837a4cc83f9f2420c7816 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
