Patch Set 1: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/#/c/4424/1/src/osmo_gsm_tester/util.py
File src/osmo_gsm_tester/util.py:

Line 45:     proc = subprocess.Popen(['patchelf', '--set-rpath', paths, 
binary], stdout=subprocess.PIPE, stderr=subprocess.PIPE, 
universal_newlines=True)
(same as the other patch ... log commandline called or use Process class)


Line 50:         raise RuntimeError('change_elf_rpath finished with err code 
%d' % proc.returncode)
(and log the command called in the error message)


-- 
To view, visit https://gerrit.osmocom.org/4424
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc356957fb3dbcf9947bfe96b671ec8c7ede33ff
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-HasComments: Yes

Reply via email to