Patch Set 1: > (1 comment) > > If I interpret the code correctly it's impossible for 'value' to be > negative at this point. So it's just to get rid of compile warning? > If so than you could, perhaps, use size_t instead of int for > 'value' type: that's what memset expects anyway.
Thank you, Max! I think it would be better to replace memset by a simple for-loop. This will also prevent possible buffer overruns in case of incorrect values are passed. -- To view, visit https://gerrit.osmocom.org/4645 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d8d78474614939659a7f24d5007b1c890776b1a Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: No
