[PATCH] osmo-ggsn[master]: sgsnemu: Make sure buffer has space for terminating-NUL

[Harald Welte]

Review at  https://gerrit.osmocom.org/4688

sgsnemu: Make sure buffer has space for terminating-NUL

In proc_ipv6_conf_read() we allocatea buffer on the stack but
forgot the terminating NUL byte.

Change-Id: I54126d8bc08c137859f2de4b47ef23fc0714fdd7
Fixes: Coverity CID#178641
---
M sgsnemu/sgsnemu.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/88/4688/1

diff --git a/sgsnemu/sgsnemu.c b/sgsnemu/sgsnemu.c
index c7ca494..0b0fba6 100644
--- a/sgsnemu/sgsnemu.c
+++ b/sgsnemu/sgsnemu.c
@@ -985,7 +985,7 @@
 static char *proc_ipv6_conf_read(const char *dev, const char *file)
 {
        const char *fmt = "/proc/sys/net/ipv6/conf/%s/%s";
-       char path[strlen(fmt) + strlen(dev) + strlen(file)];
+       char path[strlen(fmt) + strlen(dev) + strlen(file)+1];
        snprintf(path, sizeof(path), fmt, dev, file);
        return proc_read(path);
 }

-- 
To view, visit https://gerrit.osmocom.org/4688
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54126d8bc08c137859f2de4b47ef23fc0714fdd7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>