Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16355 )
Change subject: osmo_fsm: Ensure all state and event names are valid identifiers ...................................................................... Patch Set 7: (2 comments) Patchset: PS7: I think this is a good idea, but there are indeed a lot of applications that have problems. Especially event names like XXXX.ind or XXXX.req are used quite often. I would suggest to replace the dot with a '-'. File src/fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/16355/comment/61fc3595_0879039d PS7, Line 296: "state name '%s'\n", states[i].name); I think this is problematic. osmo_fsm_register() may be called before the log is set up. Maybe we should consider using printf here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If98587eff3c48a66ed2e5cc1f01a12accab5a3e7 Gerrit-Change-Number: 16355 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Tue, 18 Jan 2022 11:21:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
