Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 )
Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 2: (1 comment) File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/8dda1680_19741fbc PS2, Line 315: * Check whether the logging framework is initialized (osmo_log_info exists) */ : int log_initialized(void) : { : if (!osmo_log_info) : return 0; : return 1; : } this is a non-inline function that does nothing else but exporting the value of an (already global, exported) variable. So rather than a simple load-and-compare, the code would call a function to then perform the load-and-compare. I would say this should at the very least be an inline function inside the header file, or since the only two users are already macros, just check for osmo_log_info directly from those macros? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Fri, 21 Jan 2022 11:21:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
