Harald Welte has submitted this change and it was merged.
Change subject: l1sap: fix wrong return value of is_fill_frame()
......................................................................
l1sap: fix wrong return value of is_fill_frame()
When determining if a frame is a fill frame or not, the case
statement only conditionally handled AGCH and PCH cases. In
case a non-fill-frame was observed, the return value was uninitialized,
resulting in some non-fill-frames to be missed from GMSTAP
Change-Id: I7b46c720e34cb8ef9a91ae5da28a050439a1937d
Closes: Coverity CID#174175
---
M src/common/l1sap.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 763b355..ebcfd2f 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -335,9 +335,9 @@
if (!memcmp(data, paging_fill, GSM_MACBLOCK_LEN))
return true;
break;
- default:
- return false;
+ /* don't use 'default' case here as the above only conditionally return
true */
}
+ return false;
}
static int to_gsmtap(struct gsm_bts_trx *trx, struct osmo_phsap_prim *l1sap)
--
To view, visit https://gerrit.osmocom.org/4694
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b46c720e34cb8ef9a91ae5da28a050439a1937d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
