Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26955 )
Change subject: ranap_common_ran: add decoder for RAN/RNC originated messages ...................................................................... Patch Set 5: (6 comments) Patchset: PS5: Mostly cosmetic notes, not a merge blocker. File include/osmocom/ranap/ranap_common.h: https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/27b84377_1802f520 PS5, Line 599: funktions Tippfehler: functions File src/ranap_common_ran.c: https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/7030b23e_7396dc5d PS5, Line 90: unsuccessfulOutcome successfulOutcome? I think it's not critical, given that 'procedureCode' is present in all union members at the same position. But still may be confusing. https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/da00cf9b_8956d22e PS5, Line 102: unsuccessfulOutcome outcome? I think it's not critical, given that 'procedureCode' is present in all union members at the same position. But still may be confusing. https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/2ef5a507_79f42b5f PS5, Line 124: unsuccessful copy-paste: successful https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/0b68a617_a523c973 PS5, Line 132: unsuccessful Neither unsuccessful not successful, so this word should be removed. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Iad4c2743d4d1ddf8ad49002d1fe6866f22eb9e98 Gerrit-Change-Number: 26955 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: daniel <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Sat, 29 Jan 2022 10:16:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
