Patch Set 2: Code-Review+2 (1 comment)
https://gerrit.osmocom.org/#/c/4678/2/src/bts.cpp File src/bts.cpp: Line 1628: if (ta_delta) { no change needed now/here, just general remark: Our usual coding style would be to exit early, i.e. "if (!ta_delta) return;" which saves us one level of indent. Maybe good to follow for any future patches/changes. Don't waste time on it now. -- To view, visit https://gerrit.osmocom.org/4678 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65212f8203f1a35278890f51db038d689b2493d5 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Minh-Quang Nguyen <[email protected]> Gerrit-HasComments: Yes
