Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27129 )
Change subject: ts_102_221: Handle nested security condition data objects ...................................................................... Patch Set 2: (3 comments) File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/27129/comment/c04026c1_a6f9d08d PS1, Line 479: def from_bytes(self, binary:bytes): > Missing type hint: […] true for this specific implementation of the abstrac method, but in general i's basically any python type, just as long as it can be json-serialized. https://gerrit.osmocom.org/c/pysim/+/27129/comment/271bb72c_04830da9 PS1, Line 486: def to_bytes(self): > Missing type hint: […] Done https://gerrit.osmocom.org/c/pysim/+/27129/comment/e762d684_16b80310 PS1, Line 489: ++ > Looks like you meant '+=' here? This could be done simpler: […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icb09cf3a90303a86fc77406b8b0806b5c926f1be Gerrit-Change-Number: 27129 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 10 Feb 2022 14:13:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
