Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27127 )
Change subject: Better decode of EF.UST, EF.EST and EF.IST ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File pySim/ts_31_102.py: https://gerrit.osmocom.org/c/pysim/+/27127/comment/cfcf1ab5_5ec191e6 PS2, Line 536: (int, int) > I just copid this from ts_51_001.EF_ServiceTable. […] At least mypy is not happy about this: test.py:1: error: Syntax error in type annotation test.py:1: note: Suggestion: Use Tuple[T1, ..., Tn] instead of (T1, ..., Tn) Found 1 error in 1 file (checked 1 source file) So I think yes. pylint does not complain though. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I34f64d1043698dc385619b2fdda23cb541675f76 Gerrit-Change-Number: 27127 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 10 Feb 2022 14:59:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
