Attention is currently required from: fixeria, pespin.
iedemam has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/27134 )

Change subject: stats: add RSL line number to TCP stats name
......................................................................


Patch Set 3:

(1 comment)

This change is ready for review.

Patchset:

PS3:
Hi all,

Thanks for the reviews. After some more testing, I saw that the previous 
approach was not working.

In the two areas where a "ipa-rsl" stat name is created, both were always being 
set to zero based on the line->num value. Then I discovered that OsmoBSC is 
only using the one in this latest patch. The other one shown in a previous 
patch is on the BTS side I guess?

Regardless, now the correct TRX ID is being set for each RSL link in question. 
Stats emitted by OsmoBSC show the correct IDs.

-Michael



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/27134
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ie42d8a0cb3757f2d01a4b6d69ea2bcce400b7538
Gerrit-Change-Number: 27134
Gerrit-PatchSet: 3
Gerrit-Owner: iedemam <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 10 Feb 2022 17:23:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to