Attention is currently required from: laforge, fixeria.
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/27143 )

Change subject: make/Makefile: allow overriding '-it' for target 'run'
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
Maybe this makes it easier for other reviewers: start with make/Makefile, what 
happens is "-it" is removed from the run: target, moved to the RUN_ARGS 
variable. Then "-it" is added to RUN_ARGS of all existing users to not change 
behavior, except for ttcn3-bts-test where it should not be used anymore.

LGTM!



--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27143
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If22f682be4f004c5bb43e65098079a4f4fe6158d
Gerrit-Change-Number: 27143
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 11 Feb 2022 10:00:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to