Attention is currently required from: laforge, pespin, daniel. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27137 )
Change subject: stats: sanitize tcp stat name identifiers ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yes, the patch is simple but I don't really think the generated strings are > less ugly. […] I agree. Maybe a straightforward solution is to add a "dedup" flag to the sanitation function? After it replaces all unwanted characters with the safe character, it would then remove sequential instances of the safe character. By adding "-" to the unwanted character list, at least in this instance we then see: BEFORE: ipa-oml,r=127.0.0.1:45749<->l=127.0.0.1:3002 AFTER: ipa_oml_r_127_0_0_1_45749_l_127_0_0_1_3002 Either that or write sanitation logic for the IP connectivity string specifically. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 Gerrit-Change-Number: 27137 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Tue, 15 Feb 2022 12:05:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
