Attention is currently required from: neels, fixeria, daniel.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27197 )

Change subject: ggsn: Introduce test TC_pdp4_act_update_teid/teic
......................................................................


Patch Set 4:

(2 comments)

File ggsn_tests/GGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27197/comment/425e91d7_c053fff4
PS4, Line 391: setverdict(fail);
> Add a message to indicate what failed? […]
I can improve both as a follow up patch using shutdown() helper.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27197/comment/761b3052_7f4109d6
PS4, Line 501: espect
> expect
Ack



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27197
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic6af25866bf7efc2cabf029e49abaf15d5857592
Gerrit-Change-Number: 27197
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Wed, 16 Feb 2022 16:19:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <[email protected]>
Gerrit-MessageType: comment

Reply via email to