Attention is currently required from: osmith, neels, pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27255 )

Change subject: bsc_nat_fsm: fix SSN of OsmoBSCNAT-CN
......................................................................


Patch Set 1:

(1 comment)

File src/osmo-bsc-nat/bsc_nat_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27255/comment/a04fd6c6_a83321be
PS1, Line 202:  if (ss7_inst_init(bsc_nat->cn, "OsmoBSCNAT-CN", DEFAULT_PC_CN, 
OSMO_SCCP_SSN_BSSAP) < 0) {
So, both FSMs now use OSMO_SCCP_SSN_BSSAP. Is it expected?
Or is there another bug and we should use OSMO_SCCP_SSN_RANAP below?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27255
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: Ic0e64e002bccf1115cc53566bdab9d84dc680b03
Gerrit-Change-Number: 27255
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 18 Feb 2022 15:52:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to