Change in libosmocore[master]: BSSAP: HO Request Ack: add missing Codec List (BSS Supported)

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/27307 )


Change subject: BSSAP: HO Request Ack: add missing Codec List (BSS Supported)
......................................................................

BSSAP: HO Request Ack: add missing Codec List (BSS Supported)

Change-Id: Iab0a7b4d81592157fc111d1adb9e9f4cb53a94e9
---
M include/osmocom/gsm/gsm0808.h
M src/gsm/gsm0808.c
2 files changed, 11 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/27307/1

diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index c79da6a..b4c7803 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -246,8 +246,12 @@

        const struct sockaddr_storage *aoip_transport_layer;

+       bool more_items; /*!< set this to true iff any fields below are used */
+
+       struct gsm0808_speech_codec_list codec_list_bss_supported; /*< omit 
when .len == 0 */
+
        /* more items are defined in the spec and may be added later */
-       bool more_items; /*!< always set this to false */
+       bool more_items2; /*!< always set this to false */
 };
 struct msgb *gsm0808_create_handover_request_ack2(const struct 
gsm0808_handover_request_ack *params);

diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 4f9c687..7013d8d 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -1045,6 +1045,12 @@
        if (params->aoip_transport_layer)
                gsm0808_enc_aoip_trasp_addr(msg, params->aoip_transport_layer);

+       /* AoIP: add Codec List (BSS Supported) 3.2.2.103.
+        * (codec_list_bss_supported was added to struct 
gsm0808_handover_request_ack later than speech_codec_chosen
+        * below, but it needs to come before it in the message coding). */
+       if (params->more_items && params->codec_list_bss_supported.len)
+               gsm0808_enc_speech_codec_list(msg, 
&params->codec_list_bss_supported);
+
        /* AoIP: Speech Codec (Chosen) 3.2.2.104 */
        if (params->speech_codec_chosen_present)
                gsm0808_enc_speech_codec(msg, &params->speech_codec_chosen);

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27307
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iab0a7b4d81592157fc111d1adb9e9f4cb53a94e9
Gerrit-Change-Number: 27307
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-MessageType: newchange