Attention is currently required from: pespin, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27314 )
Change subject: ggsn: Support rx cause 'New PDP type due to network preference' ...................................................................... Patch Set 2: Code-Review+2 (3 comments) File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27314/comment/55326be4_d5b129b0 PS1, Line 366: if (not match(cpr.endUserAddress, tr_EuaIPv4(?)) and > Let's make it shorter: […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27314/comment/74a23494_66f670e3 PS1, Line 1704: cause_accept > Defined but not used, why? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27314/comment/227e84f7_7ed76e39 PS1, Line 1705: var > const, here and the line below Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iace6a4bd0c2372601dc43108ec4eb78602dbcf30 Gerrit-Change-Number: 27314 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Thu, 24 Feb 2022 13:01:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
