Attention is currently required from: pespin, daniel. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27137 )
Change subject: stats: use tcp stat names as provided ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Hi all, Apologies for changing the sense of this patch so drastically. I wasn't sure if I should start a new changeset but did want to maintain the conversation surrounding the change. After using the new TCP stats in the field for awhile now, we are seeing some issues with the name being tied to the IP+port. As described in the new commit message, this constant name change on reconnects results in distinct stat key names for what is actually a single logical stat making observation difficult. Certainly name sanitation is still an issue elsewhere and should be addressed. I wanted to tackle each item individually though. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 Gerrit-Change-Number: 27137 Gerrit-PatchSet: 3 Gerrit-Owner: iedemam <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Thu, 24 Feb 2022 15:56:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
