pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ggsn/+/27346 )


Change subject: vty: Fix cmd 'no echo-interval' doing nothing
......................................................................

vty: Fix cmd 'no echo-interval' doing nothing

It was incorrectly implemented and in practice was a NOOP.

Change-Id: I5e03c4965d05871d3f2e56675da6e75af0ec18c2
---
M ggsn/ggsn_vty.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/46/27346/1

diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c
index 1738e70..9591bf7 100644
--- a/ggsn/ggsn_vty.c
+++ b/ggsn/ggsn_vty.c
@@ -389,10 +389,9 @@
        NO_STR "Send an echo request to this static GGSN every interval.\n")
 {
        struct ggsn_ctx *ggsn = (struct ggsn_ctx *) vty->index;
-       int prev_interval = ggsn->cfg.echo_interval;
        struct sgsn_peer *sgsn;

-       if (prev_interval == ggsn->cfg.echo_interval)
+       if (ggsn->cfg.echo_interval == 0)
                return CMD_SUCCESS;

        ggsn->cfg.echo_interval = 0;

--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27346
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I5e03c4965d05871d3f2e56675da6e75af0ec18c2
Gerrit-Change-Number: 27346
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-MessageType: newchange

Reply via email to