neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/27370 )


Change subject: tweak logl to ERROR for invalid initial BSSMAP
......................................................................

tweak logl to ERROR for invalid initial BSSMAP

Related: SYS#5864
Change-Id: Idd7d763129a5acdf19cd0ae86e82b77ee0073f2f
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/70/27370/1

diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c 
b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index 33dd283..94438a8 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -272,14 +272,14 @@
        }

        if (msgb_l3len(msg) < sizeof(*bs)) {
-               LOGPFSML(fi, LOGL_NOTICE, "message too short for BSSMAP header 
(%u < %zu)\n",
+               LOGPFSML(fi, LOGL_ERROR, "message too short for BSSMAP header 
(%u < %zu)\n",
                         msgb_l3len(msg), sizeof(*bs));
                goto refuse;
        }

        bs = (struct bssmap_header*)msgb_l3(msg);
        if (msgb_l3len(msg) < (bs->length + sizeof(*bs))) {
-               LOGPFSML(fi, LOGL_NOTICE,
+               LOGPFSML(fi, LOGL_ERROR,
                         "message too short for length indicated in BSSMAP 
header (%u < %u)\n",
                         msgb_l3len(msg), bs->length);
                goto refuse;
@@ -289,7 +289,7 @@
        case BSSAP_MSG_BSS_MANAGEMENT:
                break;
        default:
-               LOGPFSML(fi, LOGL_NOTICE,
+               LOGPFSML(fi, LOGL_ERROR,
                         "message type not allowed for N-CONNECT: %s\n", 
gsm0808_bssap_name(bs->type));
                goto refuse;
        }
@@ -306,7 +306,7 @@
                break;

        default:
-               LOGPFSML(fi, LOGL_NOTICE, "No support for N-CONNECT: %s: %s\n",
+               LOGPFSML(fi, LOGL_ERROR, "No support for N-CONNECT: %s: %s\n",
                         gsm0808_bssap_name(bs->type), 
gsm0808_bssmap_name(bssmap_type));
                goto refuse;
        }

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idd7d763129a5acdf19cd0ae86e82b77ee0073f2f
Gerrit-Change-Number: 27370
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-MessageType: newchange

Reply via email to