laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27311 )
Change subject: bsc: inter-BSC HO in: expect codecs in HO Request ACK
......................................................................
bsc: inter-BSC HO in: expect codecs in HO Request ACK
Expect IEs Speech Codec (Chosen) and Codec List (BSS Supported), they
are missing in current osmo-bsc.
Related: SYS#5839
Depends: I3c0576505a3ceb3cd5cc31dc69c5bc4a86a4ea08 (osmo-bsc)
Change-Id: Ib2b4e27be241e2a92c0c3bffdf906bf22c09352b
---
M bsc/BSC_Tests.ttcn
1 file changed, 26 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 45c3239..6aefde5 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -6027,6 +6027,32 @@
f_verify_encr_info(chan_act);
f_chan_act_verify_tsc(chan_act, expect_target_tsc);
+ if (ispresent(rx_bssap.pdu.bssmap.handoverRequestAck.codecList)) {
+ if (not g_pars.aoip) {
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+ "handoverRequestAck: Expected
no Speech Codec List (BSS Supported), because this is not AoIP");
+ }
+ /* TODO: check actual codecs? */
+ } else {
+ if (g_pars.aoip) {
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+ "handoverRequestAck: Expected
Speech Codec List (BSS Supported), but none found");
+ }
+ }
+
+ if (ispresent(rx_bssap.pdu.bssmap.handoverRequestAck.speechCodec)) {
+ if (not g_pars.aoip) {
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+ "handoverRequestAck: Expected
no Speech Codec (Chosen), because this is not AoIP");
+ }
+ /* TODO: check actual codec? */
+ } else {
+ if (g_pars.aoip) {
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+ "handoverRequestAck: Expected
Speech Codec (Chosen), but none found");
+ }
+ }
+
ho_command_str :=
rx_bssap.pdu.bssmap.handoverRequestAck.layer3Information.layer3info;
log("Received L3 Info in HO Request Ack: ", ho_command_str);
var PDU_ML3_NW_MS ho_command := dec_PDU_ML3_NW_MS(ho_command_str);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27311
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib2b4e27be241e2a92c0c3bffdf906bf22c09352b
Gerrit-Change-Number: 27311
Gerrit-PatchSet: 3
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
