Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4729/1/src/host/layer23/src/mobile/gsm322.c
File src/host/layer23/src/mobile/gsm322.c:

Line 326:       OSMO_ASSERT(value > 0 && value < 128);
> if you assert > 0 here, the "== 0" below will never be used.  Sure you didn
Ah, sure, my bad... Thanks :)


-- 
To view, visit https://gerrit.osmocom.org/4729
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic12587a6c6456b8663e5357cf68a22c6d1927a07
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-HasComments: Yes

Reply via email to