Attention is currently required from: pespin.
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27463 )

Change subject: bsc_nat_sccp_inst: store ss7_inst
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1:
> So IIUC, before this commit, the field existed in the struct but was never 
> user? Strange.
before this patch the field did not exist, osmo_ss7_instance_find(dest->ss7_id) 
was used instead.


File src/osmo-bsc-nat/bsc_nat_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27463/comment/9c35883a_059e8498
PS1, Line 273:          osmo_ss7_instance_destroy(sccp_inst->ss7_inst);
> You could null the pointer like done above.
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27463
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I9a8b69fb3df17c85a67958fbca88948573d39694
Gerrit-Change-Number: 27463
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 11 Mar 2022 12:34:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to