Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27467 )
Change subject: bsc_nat_fsm: tweak forwarding log messages ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc-nat/bsc_nat.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27467/comment/42d9af46_816e7570 PS1, Line 60: snprintf(buf, sizeof(buf), "PC=%s in %s", osmo_ss7_pointcode_print(NULL, addr->pc), > Sound like we can improve/shorten this further: CN-PC=%s and RAN-PC=%s That's shorter yes, but I'd argue "PC=%s in RAN" and "PC=%s in CN" is more readable and fits better with "BSC(PC=%s)" and "MSC(PC=%s)" in later patches. You gave +1 so it seems it's not that important to you and I'll leave it as is. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27467 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I85f65ad3c15a10958fbfe97aef00fc386e85ef63 Gerrit-Change-Number: 27467 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 11 Mar 2022 12:35:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
