Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27471 )
Change subject: Reply to BSC's RESET with RESET ACK directly ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc-nat/bssap.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27471/comment/779cde45_3d2688d4 PS1, Line 70: return bssap_ran_rcvmsg_udt(addr, msg, length - sizeof(struct bssmap_header)); > shouldn't the length field check in the "if" clause above be checked against > sizeof(struct bssmap_he […] No, because sizeof(struct bssmap_header) is already substracted from length in line 95. I've based this on how it's done in OsmoBSC: https://git.osmocom.org/osmo-bsc/tree/src/osmo-bsc/osmo_bsc_bssap.c?id=663d6fed0c73c260be7b4a83a4564677a65707f9#n1124 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I3223409e25c93b625d67634caf68efe9772e2558 Gerrit-Change-Number: 27471 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 11 Mar 2022 12:35:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
