fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27489 )
Change subject: BTS_Tests: fix expectations in TC_sacch_chan_act_ho_{sync,async}
......................................................................
BTS_Tests: fix expectations in TC_sacch_chan_act_ho_{sync,async}
According to 3GPP TS 48.058:
* 4.1.3 async handover: "If the MS Power IE is present the BTS
*may* start transmission also on the SACCH".
* 4.1.4 sync handover: "If only the MS Power IE is present the BTS
*may* start transmission also on the SACCH".
"May" does not mean "shall", so osmo-bts does not.
Change-Id: I5e97944e56b7860f2d912cd8d3c978a0f1e08645
Related: SYS#5838, OS#4008, OS#4009
---
M bts/BTS_Tests.ttcn
1 file changed, 13 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/89/27489/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 5741458..7f2faff 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1074,7 +1074,9 @@
}
/* verify that given SACCH payload is present */
-private function f_sacch_present(template octetstring l3_exp) runs on ConnHdlr
{
+private function f_sacch_present(template octetstring l3_exp,
+ boolean do_fail := true)
+runs on ConnHdlr {
var L1ctlDlMessage dl;
timer T_sacch := 3.0;
L1CTL.clear;
@@ -1089,7 +1091,10 @@
}
}
[] L1CTL.receive { repeat; }
- [] T_sacch.timeout {
+ [not do_fail] T_sacch.timeout {
+ log("Timeout waiting for SACCH ", l3_exp);
+ }
+ [do_fail] T_sacch.timeout {
setverdict(fail, "Timeout waiting for SACCH ", l3_exp);
Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
@@ -1384,8 +1389,9 @@
/* enable dedicated mode */
f_l1ctl_est_dchan(L1CTL, g_pars);
- /* Verify that DL SACCH is being received */
- f_sacch_present(si5);
+ /* 4.1.3 "If the MS Power IE is present the BTS *may* start transmission
+ * also on the SACCH". "May" does not mean "shall", so osmo-bts does
not. */
+ f_sacch_present(si5, do_fail := false);
/* Send handover Access Burst and expect SACCH to remain present */
f_L1CTL_RACH(L1CTL, ho_ref, chan_nr := g_pars.chan_nr);
@@ -1460,8 +1466,9 @@
/* enable dedicated mode */
f_l1ctl_est_dchan(L1CTL, g_pars);
- /* Verify that DL SACCH is being received, because MS Power IE was sent
*/
- f_sacch_present(si5);
+ /* 4.1.4 "If only the MS Power IE is present the BTS *may* start
transmission
+ * also on the SACCH". "May" does not mean "shall", so osmo-bts does
not. */
+ f_sacch_present(si5, do_fail := false);
/* Send handover Access Burst and expect SACCH to remain present */
f_L1CTL_RACH(L1CTL, ho_ref, chan_nr := g_pars.chan_nr);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27489
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5e97944e56b7860f2d912cd8d3c978a0f1e08645
Gerrit-Change-Number: 27489
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-MessageType: newchange
