Attention is currently required from: laforge. jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26865 )
Change subject: firmware: bugfix: disable cardemu comms in local SIM mode ...................................................................... Patch Set 1: (4 comments) Patchset: PS1: > sorry for the delay, now getting back to having a look at this. […] Thanks! simtrace2 has the additional complexity of being able to run sniff firmware, as well, and so that might be why the hardware does not disconnect the SAM3 UART. In any evident, are you OK with merging this solution for the simtrace2? Also, you have two comments on the change that are still marked "Unresolved". I believe they are addressed, but I wasn't sure what the etiquette was here with respect to marking other people's comments as "resolved", and so I have left them as unresolved. PS1: Hello, Looking for a merge of this important fix for simtrace2. I had posted comments back in January, but I guess I neglected to press the "REPLY" button. Doing so now. Sorry for the delay. Regards, James File firmware/libcommon/source/mode_cardemu.c: https://gerrit.osmocom.org/c/simtrace2/+/26865/comment/73fef2e9_e71e05dc PS1, Line 87: /*! real-time state of VCC I/O line, irrespective of enabled flag */ > Understood, however in this case this commit changes the previously > understood usage of some of thes […] Done https://gerrit.osmocom.org/c/simtrace2/+/26865/comment/3e7cfd82_c7e36a86 PS1, Line 100: ; > Per comment above, I believe these changes should be reviewed as one change > request. Done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I4010f988712eac4a6af8568ccd60062f9de62449 Gerrit-Change-Number: 26865 Gerrit-PatchSet: 1 Gerrit-Owner: jtavares <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Fri, 11 Mar 2022 18:34:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: jtavares <[email protected]> Gerrit-MessageType: comment
