Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27508 )
Change subject: gsm48_make_ho_cmd(): optionally add Synchronization Indication IE ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27508/comment/ddec9b2b_4d4aaaa3 PS1, Line 562: if (!async || ho_scope & HO_INTER_BSC_IN) { > Better have the "ho_scope & HO_INTER_BSC_IN" condition first (and add > parenthesis!) to match the com […] to me it is clear, the Synchronization Indication is omitted for async intra-GERAN ack: please parenthesis around the & operation -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4e5b1163a71443d706f14ce4bfd5c2294c320432 Gerrit-Change-Number: 27508 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:58:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
