fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/27510 )


Change subject: fixup: gsm48_make_ho_cmd(): optionally add Cipher Mode Setting 
IE
......................................................................

fixup: gsm48_make_ho_cmd(): optionally add Cipher Mode Setting IE

This was overlooked during the code review.  GCC does not complain
because internally both 'enum handover_scope' and 'bool' are
interpreted as 'int'.  Found this while running my WIP testcase
TC_srvcc_eutran_to_geran_a5_3.  This change makes it pass.

Change-Id: I807fd4a0e700e54c67ca3547d9c0c1b442dd1c54
Fixes: I1d270e82d0a9b12897fc94dae4e8999aa132a22f
---
M src/osmo-bsc/handover_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/10/27510/1

diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index 5ae3787..488f370 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -1216,7 +1216,7 @@
        struct handover *ho = &conn->ho;

        struct msgb *rr_ho_cmd = gsm48_make_ho_cmd(ho->new_lchan,
-                                                  ho->async, ho->scope,
+                                                  ho->scope, ho->async,
                                                   ho->new_lchan->ms_power,
                                                   ho->ho_ref);
        if (!rr_ho_cmd) {

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27510
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I807fd4a0e700e54c67ca3547d9c0c1b442dd1c54
Gerrit-Change-Number: 27510
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-MessageType: newchange

Reply via email to